Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ui): update loader #5029

Merged
merged 6 commits into from
Mar 3, 2020
Merged

perf(ui): update loader #5029

merged 6 commits into from
Mar 3, 2020

Conversation

yesnault
Copy link
Member

@yesnault yesnault commented Feb 29, 2020

Signed-off-by: Yvonnick Esnault [email protected]

GPU: 30% before, 2% after
CPU: 23% before, 6% after.

close #4808

Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
Copy link
Member Author

yesnault commented Feb 29, 2020

with

 <div *ngIf="loader" class="sync alternate blue icon">
                <span class="">{{value}}</span>
            </div>

Capture d’écran 2020-02-29 à 16 07 16

with

 <i *ngIf="loader" class="spinner blue icon">
                <span class="">{{value}}</span>
            </i>

Capture d’écran 2020-02-29 à 16 06 41

--> results:
GPU: 30% before, 2% after
CPU: 23% before, 6% after.

Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh ovh deleted a comment from ovh-cds Feb 29, 2020
@ovh ovh deleted a comment from ovh-cds Feb 29, 2020
@yesnault
Copy link
Member Author

yesnault commented Mar 2, 2020

Results, with no data in network (Task View) and the lowest numbers.

With CSS Animation:

  • Workflow view GPU: 13% CPU: 11%
  • Pipeline view GPU 20% CPU: 12%

Gif:

  • Workflow view GPU: 4.3% CPU: 6%
  • Pipeline view GPU 6.6% CPU: 8%

Static:

  • Workflow view GPU: 1.9% CPU: 4.9%
  • Pipeline view GPU 1.9% CPU: 6%

Signed-off-by: Yvonnick Esnault <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2020

CDS Report build-all-cds#12601.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✘

Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault added 2 commits March 2, 2020 17:33
Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
@yesnault
Copy link
Member Author

yesnault commented Mar 2, 2020

Screenshots with gif (dark and not)

Capture d’écran 2020-03-02 à 17 45 45
Capture d’écran 2020-03-02 à 17 45 52

@yesnault yesnault requested a review from sguiheux March 3, 2020 13:46
@yesnault yesnault merged commit 1de9f1f into master Mar 3, 2020
@yesnault yesnault deleted the ye-perf-ui-load branch March 4, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline run view: CPU, lag
5 participants